This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
feat(jira): add action tasks #241
Merged
chuang8511
merged 18 commits into
instill-ai:main
from
YCK1130:YCK1130/jira-action-schema
Aug 23, 2024
Merged
feat(jira): add action tasks #241
chuang8511
merged 18 commits into
instill-ai:main
from
YCK1130:YCK1130/jira-action-schema
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YCK1130
requested review from
donch1989,
pinglin,
xiaofei-du and
jvallesm
as code owners
July 25, 2024 14:29
chuang8511
reviewed
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YCK1130
Left some comments.
Next step, I think you can
- create mock function to return fake data.
- create a demo pipeline for @instill-ai/product to review the pipeline. I think the schema may be hard for @instill-ai/product to review.
cc'd @AmeliaCelline @zidanehakim you will need to know the new development flow, so tag you two as well.
YCK1130
force-pushed
the
YCK1130/jira-action-schema
branch
from
July 30, 2024 23:05
7ea57c1
to
31febb9
Compare
YCK1130
force-pushed
the
YCK1130/jira-action-schema
branch
from
July 31, 2024 09:56
31febb9
to
c814e8d
Compare
YCK1130
force-pushed
the
YCK1130/jira-action-schema
branch
2 times, most recently
from
August 11, 2024 23:26
f3c103b
to
a74e5fc
Compare
YCK1130
force-pushed
the
YCK1130/jira-action-schema
branch
from
August 12, 2024 23:21
0398b00
to
e6ef7a5
Compare
YCK1130
force-pushed
the
YCK1130/jira-action-schema
branch
from
August 21, 2024 16:16
e6ef7a5
to
2834e4f
Compare
chuang8511
reviewed
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments.
YCK1130
force-pushed
the
YCK1130/jira-action-schema
branch
from
August 22, 2024 20:42
2834e4f
to
19f86d8
Compare
Hi @YCK1130 I have fixed the test code. |
YCK1130
force-pushed
the
YCK1130/jira-action-schema
branch
from
August 23, 2024 14:19
d936cb5
to
1e3e184
Compare
chuang8511
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
donch1989
pushed a commit
that referenced
this pull request
Aug 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.26.0-beta](v0.25.0-beta...v0.26.0-beta) (2024-08-29) ### Features * add milvus component ([#299](#299)) ([a48c211](a48c211)) * add zilliz component ([#297](#297)) ([92726ef](92726ef)) * **artifact:** improve artifact component ([#289](#289)) ([44ea196](44ea196)) * **document:** improve document operator ([#287](#287)) ([c0d8d31](c0d8d31)) * **hubspot:** add 4 tasks and modify Retrieve Association task and Get Thread task ([#265](#265)) ([62903ec](62903ec)) * introduce interfaces InputReader and OutputWriter ([#294](#294)) ([e26ecef](e26ecef)) * **jira:** add action tasks ([#241](#241)) ([e756e31](e756e31)) * make the API key be optional for Instill-Credit-supported component ([#305](#305)) ([0f9a7b2](0f9a7b2)) * **openai:** revert go-openai and add support for streaming ([#301](#301)) ([aa605fa](aa605fa)) * **openai:** use go-openai client ([#295](#295)) ([aa20a16](aa20a16)) * **sql:** add ssl/tls input as base64 encoded and move engine to setup ([#282](#282)) ([390e2b8](390e2b8)) * use error type for component definition not found error ([#302](#302)) ([cfcee78](cfcee78)) * **web:** improve web operator ([#292](#292)) ([1da84af](1da84af)) ### Bug Fixes * **document:** catch the error if there is no data in sheet ([#296](#296)) ([21bebbd](21bebbd)) * **hubspot:** fix test code ([#298](#298)) ([98c4261](98c4261)) * **text:** fix chunk position bugs ([#307](#307)) ([cfc9076](cfc9076)) * **text:** fix the bug if there are 2 exact same chunks ([#308](#308)) ([b58909f](b58909f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
8/12 Update
I have implemented all functions to connect to the real API and found some tasks are related to some APIs that are not compatible with the current version of Jira. The remaining tasks are:
7/31 Update
@chuang8511 Hi, I added three more tasks and moved the schema from v1 to v0 as #205 is merged. There are 5 new tasks now:
7/25
Note that only the last 3 tasks need to be reviewed, as the others are under review at #205